PluggableUSB complete port #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 7, 2015
This way all the 64 bytes available can be filled up
* fix in_endpoint buffer size (was too big) * use the same EP for CDC_ENDPOINT_OUT and CDC_ENDPOINT_IN (different buffers) * fix CDC_ENDPOINT_IN ep type
|
|
||
| void USB_Handler(void) | ||
| { | ||
| if (usb_isr) |
There was a problem hiding this comment.
why not putting the vectors in RAM instead of using this trick?
SCB->VTOR=new vectors address
The shortcut has some issues: - sometimes it fails when sending an odd number of bytes (may be due to memory alignment?) - the data pointer should point to "stable" data (and this is not guaranteed by caller, it may be some sort of temporary buffer) - the SRAM is not guaranteed to start at 0x20000000 All the above problems must be properly fixed before reenabling this part
facchinm
force-pushed
the
pluggable-hid
branch
from
de17650 to
87bbaaa
Compare
|
✅ Build completed. ⬇️ Build URL: ℹ️ To test this build:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should apply on the top of PR #27